search

samayo / country-json

A simple data of the world by country each in JSON format.
https://data.world/samayo
MIT License
1.07k stars 804 forks source link

Create currency-by-country-abbreviation.json #146

Closed guerrerocarlos closed 4 years ago

samayo commented 4 years ago

Hi, thanks for the PR.

I think this data set is already documented as two separate data. (abbreviation, currency code) I don't think there is a need to add another set. Let me know if you think this will help in other ways.

guerrerocarlos commented 4 years ago

Hello @samayo!

Yeah I know, I created this dataset from those two you already have, as today I needed precisely the mapping between country codes and currencies and couldn't find it anywhere, so I did it and thought maybe other people would need it too, so it would save them time if I made this PR.

samayo commented 4 years ago

Thanks for the thought, but I don't know why you didn't use both data sets and merge the contents? That is how the library is mean to be used and why all the countries have fixed place in file. If I merge the currency and country codes in a new file, then the same would be needed for other contents also. Thanks but this would add verbosity to the data sets, it is better to use two or more files to create new data