search

samayo / country-json

A simple data of the world by country each in JSON format.
https://data.world/samayo
MIT License
1.07k stars 805 forks source link

Issue on json files #80

Closed JosiYosi closed 6 years ago

JosiYosi commented 6 years ago

These files has some issue concerning data of some countries. There is no countries name Kosovo, Montenegro, Serbia. There is an old name of these new countries called Yugoslavia. There is no more country name Yugoslavia right now. Rather it should be replaced by those three countries mentioned above. Need big time fix.

samayo commented 6 years ago

Yeah, there needs some review and fix for the countries mentioned. Can you point out which file needs a fix, or you can send a pull request if you can

JosiYosi commented 6 years ago

If you look all the files, there are no data for the country Kosovo, Montenegro and Serbia in all json files. So technically speaking, Whoever is going to fix it, need to include those three countries. There is no such country called Yugoslavia anymore, that one need to be omitted, and replaced by those three countries( Kosovo, Montenegro and Serbia). I wish I could fix some of the files as much as I can, but it says that I need some kind of permission. So, someone need to take care of it. Thanks!

samayo commented 6 years ago

hmm.. you don't need permission to fix something. Just fix on the one you forked and create a pull request. But I've been thinking about updating the repo and fixing this issues so, eventually I will.

JosiYosi commented 6 years ago

Ok I will try then , thanks

samayo commented 6 years ago

feel free to send a PR for the other recognized countries if you are still interested.