search

samba-in-kubernetes / samba-container

Build Samba Container Images / Kubernetes & Container Runtime Example Files
GNU General Public License v3.0
48 stars 18 forks source link

Enable creation of CentOS based AD server images with nightly builds of Samba #142

Closed anoopcs9 closed 1 year ago

anoopcs9 commented 1 year ago

@Mergifyio rebase

mergify[bot] commented 1 year ago

rebase

✅ Branch has been successfully rebased

anoopcs9 commented 1 year ago

combined

build-nightly-ad-server (centos, amd64) and test-nightly-ad-server-kubernetes (centos, amd64) are the new ones.

obnoxxx commented 1 year ago

@anoopcs9 why has this been moved out of draft status but labeled do-not-merge?

anoopcs9 commented 1 year ago

@anoopcs9 why has this been moved out of draft status but labeled do-not-merge?

I forgot to remove the label 😄

obnoxxx commented 1 year ago

@mergifyio rebase

mergify[bot] commented 1 year ago

rebase

✅ Branch has been successfully rebased

anoopcs9 commented 1 year ago

Thanks for the PR, @anoopcs9 ! it generally looks good to me, but the test-nightly-ad-server-kubernetes job for centos is failingf with Container image "samba-ad-server:centos-nightly" is not present with pull policy of Never - some fix is needed.

It was a spurious failure.