samba-in-kubernetes / samba-container

Build Samba Container Images / Kubernetes & Container Runtime Example Files
GNU General Public License v3.0
47 stars 17 forks source link

hack: some tweaks for the build-image script #164

Closed phlogistonjohn closed 8 months ago

phlogistonjohn commented 8 months ago

Avoid passing the --arch option to podman for building the host architecture.

Add an option to skip adding tags meant primarily for backwards compatibility with the earlier makefile based builds.

phlogistonjohn commented 8 months ago

However: top-level doc-string still implies using explicit --arch option. Better to modify the doc string as well to avoid confusion in the future.

I'm not sure what you mean. if you mean the doc-comment at lines 2-36 those are the --arch flags that are passed to this script to set the target arch. With the new change if you don't supply --arch or the value of --arch option to build-image is the same as the host's architecture we'll skip passing an --arch to podman.

synarete commented 8 months ago

However: top-level doc-string still implies using explicit --arch option. Better to modify the doc string as well to avoid confusion in the future.

I'm not sure what you mean. if you mean the doc-comment at lines 2-36 those are the --arch flags that are passed to this script to set the target arch. With the new change if you don't supply --arch or the value of --arch option to build-image is the same as the host's architecture we'll skip passing an --arch to podman.

Fair enough.

phlogistonjohn commented 8 months ago

@anoopcs9 @synarete PTA2L