samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
117 stars 24 forks source link

makefile and kustomize workflow improvements #114

Closed phlogistonjohn closed 3 years ago

phlogistonjohn commented 3 years ago

Before these patches, the makefile (via kustomize) would always alter the state of the repo, specifically config/manger. Along with some general improvements, these changes allow a developer to opt into alternate paths for the "top level" kustomize overlay. This permits the user to have a personal space of kustomizations that do not alter the state of the git repo. We support a top level shortcut to setting paths directly called "DEVELOPER" that can be set to a non-empty value and causes the path config/developer to be used. Aside from a readme explaining the pupose of this dir, the content of the dir is ignored.

All this comes out of my own annoyances of having to git stash or other hoop-jumping prior to rebasing/changing branches/etc or risk losing "hand rolled" kustomization.yaml file contents. But it should be more generally useful too.