search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
117 stars 24 forks source link

kustomization.yaml in developer guide is incomplete #136

Closed spuiuk closed 2 years ago

spuiuk commented 2 years ago

The contents for config/developer/kustomization.yaml should also include

resources:

for it to work properly.

Without this, the command make DEVEOPER=1 deploy will fail with the output

/home/sprabhu/go/bin/controller-gen "crd:trivialVersions=true,crdVersions=v1" rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases cd config/developer && /home/sprabhu/go/bin/kustomize edit set image controller=quay.io/spuiuk/smbshare_devel:test /home/sprabhu/go/bin/kustomize build config/developer | kubectl apply -f - Error: merging from generator &{0xc0004b6360 { map[] map[]} {{system controller-cfg merge {[SAMBA_OP_SAMBA_DEBUG_LEVEL=10 SAMBA_OP_CLUSTER_SUPPORT=ctdb-is-experimental] [] [] } }}}: id resid.ResId{Gvk:resid.Gvk{Group:"", Version:"v1", Kind:"ConfigMap", isClusterScoped:false}, Name:"controller-cfg", Namespace:"system"} does not exist; cannot merge or replace

spuiuk commented 2 years ago

You also need to add namespace: samba-operator-system namePrefix: samba-operator-

to the kustomization.yaml file for it to work properly. Else it installs the operator in the namespace system instead.