samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
110 stars 24 forks source link

YAML files "churn" when executing make commands #140

Closed phlogistonjohn closed 2 years ago

phlogistonjohn commented 2 years ago

I think this is fallout from #131

When I run commands such as make manifests many of the YAML files show as changed to git. However, I've not touched the sources. I think we should do one of the following:

synarete commented 2 years ago

Tools like controller-gen does not enforce strict output-yaml format (as required by yamllint). Option 2 (Configure the make file to automatically format the output of make manifests) is best IMHO.

synarete commented 2 years ago

Tools like controller-gen does not enforce strict output-yaml format (as required by yamllint). Option 2 (Configure the make file to automatically format the output of make manifests) is best IMHO.

synarete commented 2 years ago

https://github.com/samba-in-kubernetes/samba-operator/pull/143