search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
110 stars 24 forks source link

Improve developer workflow in makefile and docs #142

Closed phlogistonjohn closed 2 years ago

phlogistonjohn commented 2 years ago

Previously, the docs didn't explain that the example YAML snippets were to be added to a stock kustomization.yaml, nor did it explain that the makefile could help create this kustomization.yaml. Now we can easily initialize the developer dir with make developer-dir DEVELOPER=1 and we improve the docs to match.

Fixes: #136

synarete commented 2 years ago

LGTM. While reviewing, I noticed two minor issues, which worth squash into this PR: https://github.com/synarete/samba-operator/commit/2fdedbcda3ce2d788333e34d417debb0db622325 https://github.com/synarete/samba-operator/commit/846a99f615f003cec88a0610630c124d907d9937

phlogistonjohn commented 2 years ago

PR updated, PTAL. @spuiuk @synarete

phlogistonjohn commented 2 years ago

I think the CI is actually failing due to this PR's changes. It is certainly going to be part of the makefile changes, not the doc text but I need to hunt down what it is because the changes should have been minor.

phlogistonjohn commented 2 years ago

PR updated. I finally figured out the issue wrt why the makefile changes were breaking the CI. Details are in a comment in the change. When you have a free moment, PTAL @spuiuk @synarete

anoopcs9 commented 2 years ago

/test centos-ci/sink-clustered/mini-k8s-1.21