search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
120 stars 24 forks source link

OpenShift deploy [2] #148

Closed synarete closed 2 years ago

synarete commented 2 years ago

When deploying over OpenShift, need to setup SCC 'anyuid' to samba-server pod. Configure the appropriate ServiceAccount, Role and RoleBinding from within samba-operator.

anoopcs9 commented 2 years ago

/test centos-ci/sink-clustered/mini-k8s-1.22

synarete commented 2 years ago

1) SCC should be configured once (and only once) for each samba-operator-system, hence it is triggered by SmbCommonConfig (same as network-specific settings, or, in the future, namespace-labeling for Prometheus metrics scraping). An attempt to create SmbShares without SmbCommonConfig over OpenShift will yield pod failure due to missing permissions. IMHO it is a valid requirement from OpenShift users to create SmbCommonConfig as part of their smb setup.

synarete commented 2 years ago

2) The override option is an interesting question. It is a fine balance between developer's flexibility and code maintenance/complexity. In need to think about it a bit more, and we should probably also discuss it f2f.

synarete commented 2 years ago

3) SCC (and its related Role and RoleBinding) is associated to smb-server pods via the ServiceAccount. Indeed, it is somewhat hidden and hard-to-spot binding:

https://github.com/synarete/samba-operator/blob/ss-openshift-deploy2/internal/resources/pods.go#L670

https://github.com/synarete/samba-operator/blob/ss-openshift-deploy2/internal/resources/scc.go#L228

ibotty commented 2 years ago

Any news? It would be great to not have to configure the rolebindings manually for every namespace a share lives in.

synarete commented 2 years ago

Any news? It would be great to not have to configure the rolebindings manually for every namespace a share lives in.

@ibotty OpenShift patches are sill under review (see #216). Unfortunately, it did not make make it to v0.2 but most likely will be ready for next release. I build and test a custom samba-operator over openshift (4.8) on a daily basis. Feel free to use it and let me know if you have any problems: quay.io/ssharon/sink:latest

phlogistonjohn commented 2 years ago

I'm making an "executive decision" to close this PR. AFAIK, the feature set here was superseded by other PRs that are now merged and there's no expectation that this PR will ever be merged. If I'm wrong, feel free to reopen it.