search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
120 stars 24 forks source link

Add support for adding annotations to smb share pods #165

Open giskou opened 2 years ago

giskou commented 2 years ago

Either clone the annotations from the SmbShare resource or have them defined in the CRD

phlogistonjohn commented 2 years ago

Hi there, I think that I would be inclined to pass that information to pods via the SmbCommonConfig resource. Would that be suitable for your use case?

Because this is a young project I'm always on the lookout for what others want to do with this operator. I'm curious what specific annotations you're looking to add to get a better sense of what we may add in the CRDs themselves in the future!

Thanks!

giskou commented 2 years ago

Hello,

I wanted to add some velero annotations to backup the smb volumes but I found an alternative to that.

phlogistonjohn commented 2 years ago

That's very interesting, thanks! I do this this a worthwhile point and so I hope you don't mind but I will reopen it.