samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes

Apache License 2.0

108 stars 24 forks source link

tests: ensure samba-metrics sidecar is responsive #194

Closed synarete closed 2 years ago

synarete commented 2 years ago

Issue a curl from samba container to samba-metrics sidecar container in order to verify samba-metrics is responsive with valid output. Execute the curl command within the pod itself.

Enabled only if 'samba-metrics' container exists in pod.

Signed-off-by: Shachar Sharon ssharon@redhat.com

phlogistonjohn commented 2 years ago

Code looks ok but the CI keeps failing. Let's double check that we're just getting unlucky with flaky tests. Thanks.

anoopcs9 commented 2 years ago

/retest centos-ci/sink-clustered/mini-k8s-1.23

synarete commented 2 years ago

@anoopcs9 @phlogistonjohn CI testing keep on failing on this PR as well as my other (trivial) PR#196. I re-checked both on my setup (with minikube) and PASS with not errors. Any idea what could cause those failures?

anoopcs9 commented 2 years ago

@anoopcs9 @phlogistonjohn CI testing keep on failing on this PR as well as my other (trivial) PR#196. I re-checked both on my setup (with minikube) and PASS with not errors. Any idea what could cause those failures?

I'm looking into CentOS CI test failures..I'm able to reproduce where I am seeing following errors from Ceph cluster which prevents it to come up HEALTHY:

MON_CLOCK_SKEW MON_DISK_LOW

clock skew is surprising but I think I figured out a way to get around MON_DISK_LOW error.

anoopcs9 commented 2 years ago

@anoopcs9 @phlogistonjohn CI testing keep on failing on this PR as well as my other (trivial) PR#196. I re-checked both on my setup (with minikube) and PASS with not errors. Any idea what could cause those failures?

I'm looking into CentOS CI test failures..I'm able to reproduce where I am seeing following errors from Ceph cluster which prevents it to come up HEALTHY:

MON_CLOCK_SKEW MON_DISK_LOW

clock skew is surprising but I think I figured out a way to get around MON_DISK_LOW error.

197 should fix rook-ceph errors from CentOS CI test runs.

synarete commented 2 years ago

@anoopcs9 @phlogistonjohn CI testing keep on failing on this PR as well as my other (trivial) PR#196. I re-checked both on my setup (with minikube) and PASS with not errors. Any idea what could cause those failures?

I'm looking into CentOS CI test failures..I'm able to reproduce where I am seeing following errors from Ceph cluster which prevents it to come up HEALTHY: MON_CLOCK_SKEW MON_DISK_LOW clock skew is surprising but I think I figured out a way to get around MON_DISK_LOW error.

197 should fix rook-ceph errors from CentOS CI test runs.

Cool! many thanks @anoopcs9