samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
108 stars 24 forks source link

samba-operator-controller-manager deployment on openshift has minimal hardcoded ressource limits #195

Open turricum opened 2 years ago

turricum commented 2 years ago

oc edit deployment/samba-operator-controller-manager and then:


       resources:
          limits:
            cpu: 100m
            memory: 100Mi
          requests:
            cpu: 100m
            memory: 20Mi

the results are Out of Memory fails. So i changed it manually and it works. The Values are to small ... (0,1 Core and 20M Memory)

ibotty commented 2 years ago

On this cluster it constantly uses a little under 128Mi. Is there data on how much it's expected to use or should it be configurable?

phlogistonjohn commented 2 years ago

The plan is to make a number of pod scheduling parameters & resource limits, etc configurable via the SmbCommonConfig resource. Thank you for the issue!