search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
108 stars 24 forks source link

Set mount path permissions #200

Closed spuiuk closed 2 years ago

spuiuk commented 2 years ago

Patch to set the permissions on the mount point of the smbshare to 0700 by default using the initialize-share-perms permissiona handler. Accompanying this change is the integration test to check if the permissions handler was run against the mount path.

spuiuk commented 2 years ago

/retest centos-ci/sink-clustered/mini-k8s-1.23

phlogistonjohn commented 2 years ago

@spuiuk I"ve restarted the test 4 times in a row and it's been failing consistently. Can you please check that the changes themselves are not the cause of the test faliures? Thanks.

spuiuk commented 2 years ago

Error: Error: Received unexpected error: too many pods match selector (opts: {Namespace:samba-operator-system LabelSelector:samba-operator.samba.org/service=tshare1 MaxFound:1 MinFound:0}; pods: [])

Looks like it is waiting on some cleanup. Unlikely to be caused by permission changes. The corresponding tests on the CentosCI have passed.

Let me try kicking this off again.

spuiuk commented 2 years ago

All clear now :)

phlogistonjohn commented 2 years ago

OK, cool. I guess I just had bad luck.