search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
120 stars 24 forks source link

Add centosci test target for kubernetes 1.24 #204

Closed phlogistonjohn closed 2 years ago

phlogistonjohn commented 2 years ago

No rush on this one, but we're testing our PRs on k8s 1.23 but 1.24 was released earlier this month. I think that we should target 1.24 (only) for a while and then consider widening the number of kube versions we test against later this year. Feel free to discuss.

anoopcs9 commented 2 years ago

This is something I accidentally got to try 2 weeks back with then latest minikube and it failed. I'll investigate more..

anoopcs9 commented 2 years ago 
May 28 06:27:49 minikube kubelet[4658]: Error: failed to parse kubelet flag: unknown flag: --cni-conf-dir
. . .
May 28 06:33:38 minikube kubelet[4652]: Error: failed to parse kubelet flag: unknown flag: --network-plugin

Issue reported is now closed but a release is yet to happen.

phlogistonjohn commented 2 years ago

Cool. Let's just keep an eye on minikube and try again once they release

anoopcs9 commented 2 years ago

Update: I tried minikube v1.26.0-beta.1 which includes the fix for https://github.com/kubernetes/minikube/issues/13945 and tests completed successfully.

Waiting for an official release...

anoopcs9 commented 2 years ago

samba_sink-mini-k8s-1.24-clustered is now created.

Minikube v1.26.0 released a week back with support for Kubernetes v1.24.