search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
108 stars 24 forks source link

resources: pass smbdVols to buildEnsureShareCtr #207

Closed synarete closed 2 years ago

synarete commented 2 years ago

Commit b140141 ("resources: create ensure-share-paths init container") introduced a new init container, which changes the mode of share's directory. Unfortunately, in buildADPodSpec we pass the wrong volumes slice (a slice which does not have the share volume). This bug is evident only when running with smbmetrics enabled, on OpenShift.

Signed-off-by: Shachar Sharon ssharon@redhat.com

phlogistonjohn commented 2 years ago

Just to clarify, are you saying that the metrics container needs the share data volume? If so, it's something I'd like to avoid, but won't block - just track for future improvement. Otherwise change looks fine and I'm willing to approve once we've discussed this.

synarete commented 2 years ago

Just to clarify, are you saying that the metrics container needs the share data volume? If so, it's something I'd like to avoid, but won't block - just track for future improvement. Otherwise change looks fine and I'm willing to approve once we've discussed this.

It is not for the metrics container. It is for the ensure-share-create (a.k.a chmod) container.