search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
108 stars 24 forks source link

config: default to latest samba operator image #210

Closed phlogistonjohn closed 2 years ago

phlogistonjohn commented 2 years ago

Since using the Operator SDK to create the initial kustomization files we've defaulted to 'controller:latest' in the base yamls. However, this means one must use kustomize to set the image to something usable. Typically, we've been doing this using the Makefile. However, now that we've well established that the canonical image for the operator is at 'quay.io/samba.org/samba-operator' there's really no need to require the image to be overridden. Update the manager base YAML to default to the canonical operator image repo - and update the makefile to match.

Note: if you do have an existing kustomization.yaml referring to 'controller' you need to update that manually

spuiuk commented 2 years ago

At the moment, the latest tag points to the latest devel build. Should this continue to point to the latest devel version or should it point to the latest released version?

phlogistonjohn commented 2 years ago

At the moment, the latest tag points to the latest devel build. Should this continue to point to the latest devel version or should it point to the latest released version?

I think its most common for a "young" project to have latest track development code. If the project matures we can reevaluate, but for now I think this is the right choice.