search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
120 stars 24 forks source link

makefile: minor fixes needed to match planned tagging format #215

Closed phlogistonjohn closed 2 years ago

phlogistonjohn commented 2 years ago

We want the makefile to help us embed the version and hash of the git checkout used for the build. Fix getting the hash when a tag is applied and when the tag is in the form vX.Y (rather than vX.Y.Z).

phlogistonjohn commented 2 years ago

For expedience I already applied this change for the release, however I figured we can do a proper review at our normal leisurely pace having gotten the release done. :-)

anoopcs9 commented 2 years ago

/retest centos-ci/sink-clustered/mini-k8s-1.23