search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
120 stars 24 forks source link

OpenShift with Metrics #216

Closed synarete closed 2 years ago

synarete commented 2 years ago

Deploy samba-operator over OpenShift cluster, with enabled metrics-exporter side-car container. Takes care of all missing OpenShift configuration by reconcile of SmbCommonConfig.

This patch-set is intended for next development cycle (v0.3)

phlogistonjohn commented 2 years ago

Things are looking pretty decent IMO. Some of the openshift-iness goes a little over my head, but I can follow a fair portion of it. I have a bunch of small non-functional things that need fixing. We can discuss testing later in a call or in a followup issue.

phlogistonjohn commented 2 years ago

I'm not sure if you think it's ready for another round of review, but I note that the "scarping" commit message typo still seems to be present. Let me know when you think its good to go for reviews and I'll take another look. Thanks!

phlogistonjohn commented 2 years ago

/retest centos-ci/sink-clustered/mini-k8s-1.23

phlogistonjohn commented 2 years ago

/retest centos-ci/sink-clustered/mini-k8s-1.23