search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
120 stars 24 forks source link

More integration test organizational cleanups #224

Closed phlogistonjohn closed 2 years ago

phlogistonjohn commented 2 years ago

Depends on: #223

There were far too many context.TODO calls in the integration tests and they were reproducing. This also prepares for adding information about the parameters of the test for logging/tracking purposes.

dpulls[bot] commented 2 years ago

:tada: All dependencies have been resolved !

phlogistonjohn commented 2 years ago

/test centos-ci/sink-clustered/mini-k8s-1.23

phlogistonjohn commented 2 years ago

/test centos-ci/sink-clustered/mini-k8s-1.23

phlogistonjohn commented 2 years ago

/retest centos-ci/sink-clustered/mini-k8s-1.23

phlogistonjohn commented 2 years ago

I'll keep re-running the centos ci job as needed but I'll point out that the PR that depends on this #225 resolves some of the common ci flakes. I'd appreciate it if the team reviewed this without worrying too much about having the CI pass as I may opt to just ignore centosci until #225.

phlogistonjohn commented 2 years ago

/retest centos-ci/sink-clustered/mini-k8s-1.23

phlogistonjohn commented 2 years ago

/retest centos-ci/sink-clustered/mini-k8s-1.23

phlogistonjohn commented 2 years ago

@synarete @spuiuk @anoopcs9 - please review. Despite our current CI woes I do think this is an improvement. I am willing to merge this even with some CI failures if we agree the failures are not due to the code change in question while we work through the CI issues. Thanks!