search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
120 stars 24 forks source link

smbcc: Add 'dos charset' option to Global smb.conf defaults #229

Closed anoopcs9 closed 2 years ago

anoopcs9 commented 2 years ago

dos charset option allows us to specify a particular charset which in turn helps to avoid the following warning message on clients in the absence of 850 charset:

dos charset 'CP850' unavailable - using ASCII

anoopcs9 commented 2 years ago

/test centos-ci/sink-clustered/mini-k8s-1.24

anoopcs9 commented 2 years ago

/test centos-ci/sink-clustered/mini-k8s-1.24

There is an ongoing issue with CentOS CI environment where jenkins pod is getting restarted frequently. This can coincide with jobs running around that time which initially caused failure here. Hopefully the next run goes through well.

phlogistonjohn commented 2 years ago

OK, threre's also an open-coded uses of smbclient package in mount_path_test.go that I didn't notice before. I'm filing an issue on that and will follow up.

phlogistonjohn commented 2 years ago

Filed #230