search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
120 stars 24 forks source link

support configuration changes #233

Closed phlogistonjohn closed 2 years ago

phlogistonjohn commented 2 years ago

These changes add the ability to change the configuration of an existing share and have that configuration change reflected in the pod(s) hosting the share.

In addition to the general infrastructure needed to make configuration changes the operator will honor edits to the readOnly and browseable fields.

Changes to the readOnly field are then used to create a functional test for the feature.

phlogistonjohn commented 2 years ago

Acked-By: Sachin Prabhu sprabhu@redhat.com

Do we need to update the documentation?

Maybe, as I'm using this as a stepping stone to getting multiple shares on one serverGroup, I personally would wait until that feature is added. If you want to do it as a separate PR, by all means, go ahead!