search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
103 stars 24 forks source link

controllers: removed unused Scheme field #244

Closed synarete closed 1 year ago

synarete commented 1 year ago

Having an unused and uninitialized 'Scheme' member to SmbCommonConfigReconciler is confusing; a naive user may assume that it is set to non-nil reference which end with run-time panic.

Signed-off-by: Shachar Sharon ssharon@redhat.com

synarete commented 1 year ago

Don't we have similar situation with SmbSecurityConfigReconciler?

@anoopcs9 Good catch! I will update this PR with appropriate fix.

phlogistonjohn commented 1 year ago

... and centos ci passed too :exclamation: :exclamation: :exclamation:

anoopcs9 commented 1 year ago

... and centos ci passed too exclamation exclamation exclamation

🕺🏻 🕺🏻

synarete commented 1 year ago

... and centos ci passed too exclamation exclamation exclamation

🕺🏻 🕺🏻

Cool!