search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
113 stars 24 forks source link

build: fix minor 'make check' error with go1.19 #245

Closed synarete closed 2 years ago

synarete commented 2 years ago

Fixed minor lint error when compiling the code with go1.19 (amd64, Fedora35).

Signed-off-by: Shachar Sharon ssharon@redhat.com

synarete commented 2 years ago

If this is related to a similar error I saw myself the other day (unstable iexport format). I think an alternative way to "fix" it that doesn't disable checks would be to update to a newer version of golangci-lint (see 33de25a for my "hack-around")

In that case, I will try to solve this (an other) by upgrading to newer version of golangci-lint. Please ignore this PR.

anoopcs9 commented 2 years ago

Fixed minor lint error when compiling the code with go1.19 (amd64, Fedora35).

I also encountered this make check error while working on #242 which I mentioned as a comment there.