search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
103 stars 24 forks source link

planner: fixes and tests for configuration update #249

Closed phlogistonjohn closed 1 year ago

phlogistonjohn commented 1 year ago

There are a number of code-paths the planner takes to update the smbcc configuration. This initial set of unit tests gets us to around 77% coverage of configuration.go, checking some of the most common of these paths.

phlogistonjohn commented 1 year ago

Note that updating the configuration with a 2nd share is not supported by the operator today. The fix here will be needed when we start supporting that as a valid action in the operator. That said, it's nice to have the library function work correctly anyways :-)

phlogistonjohn commented 1 year ago

Giving this until Thursday (09-28) for any additional reviews.