search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
103 stars 24 forks source link

Go version >= 1.17 #253

Closed synarete closed 1 year ago

synarete commented 1 year ago

Set minimal supported version of Go to 1.17. Updated github workflow accordingly.

Prefer 1.17 over 1.18 as some of our auxiliary build tools (linters) are still buggy when used with go1.18 features (namely, generics).

synarete commented 1 year ago

Everything looks good with one minor caveat - the list of packages in go.mod looks longer that I expected (I expected new stuff in that 2nd section, but not that much). Can you please verify you ran go mod tidy? If so, I'll happily approve - I just want to double check the list isn't longer than necessary.

I re-run go mod tidy and got same result, both with go1.17 and go1.18. May need to do deeper dive into https://go.dev/ref/mod#go-mod-file-require but I would prefer to do so in a separate PR.

phlogistonjohn commented 1 year ago

No worries, I just wanted to double check it. Thanks.

phlogistonjohn commented 1 year ago

I'll wait approx. one day before merging for other feedback. I will ignore the centos ci status for this PR and merge w/o waiting for success from that CI.

anoopcs9 commented 1 year ago

/test centos-ci/sink-clustered/mini-k8s-1.24