search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
103 stars 24 forks source link

planner: add Prune function to remove shares #258

Closed phlogistonjohn closed 1 year ago

phlogistonjohn commented 1 year ago

Nothing uses this change yet, but it adds a function to the internal planner library to Prune shares from an otherwise populated smbcc config. Once the operator supports adding multiple shares to one instance we'll also need a way to remove them.

With unit tests.

phlogistonjohn commented 1 year ago

/jenkins retest sink-clustered/mini-k8s-1.24

phlogistonjohn commented 1 year ago

/retest centos-ci/sink-clustered/mini-k8s-1.24

phlogistonjohn commented 1 year ago

I would pay money for some kind of feedback that I've issued the correct command to rerun the jenkins tests.

phlogistonjohn commented 1 year ago

@spuiuk can you please re-ACK? I squashed the patches and so github dismissed the review.