search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
103 stars 24 forks source link

golangci-list: disable deprecated linters #261

Closed phlogistonjohn closed 1 year ago

phlogistonjohn commented 1 year ago

Makes some noisy warnings go away. I have not checked if anything newer has been added. I generally prefer revive.

Signed-off-by: John Mulligan jmulligan@redhat.com

anoopcs9 commented 1 year ago

Makes some noisy warnings go away.

Any specific Go version which triggers those warnings? On my system with Go v1.18 I couldn't see any warnings for make check-golangci-lint.

I have not checked if anything newer has been added. I generally prefer revive.

I could see varcheck, deadcode and structcheck in the list of disabled linters but only with golangci-lint v1.49.x.

phlogistonjohn commented 1 year ago

In order to close the loop on things in a timely manner I'm going to use my admin rights to merge this despite @synarete approval getting dismissed automatically since all I changed was what was asked for.