Use gitlint

[synarete]

Use gitlint to lint commit messages. Do not run other jobs in case gitlint check fails.

[phlogistonjohn]

Hi @synarete I bet you're aware of this already but just in case you're not - the change is not passing. I think github is doing something funny with it's "Merge" commit because the default gitlint config is to skip merge commits.

Additionally, I was playing with gitlint locally and found that by default it only checks the current commit. I think we need to pass --commits origin/master.. or something along those lines to have it check every commit on the branch. It may be useful to add a makefile rule first and then just invoke make from the github action.

[synarete]

Hi @synarete I bet you're aware of this already but just in case you're not - the change is not passing. I think github is doing something funny with it's "Merge" commit because the default gitlint config is to skip merge commits.

Additionally, I was playing with gitlint locally and found that by default it only checks the current commit. I think we need to pass --commits origin/master.. or something along those lines to have it check every commit on the branch. It may be useful to add a makefile rule first and then just invoke make from the github action.

@phlogistonjohn Thanks for your comments; I refactored this PR based on your feedback. Please review, especially the first commit ("makefile: run gitlint via make rule").

[anoopcs9]

@Mergifyio rebase

[mergify[bot]]

⚠️ This pull request got rebased on behalf of a random user of the organization. This behavior will change on the 1st February 2023, Mergify will pick the author of the pull request instead.

To get the future behavior now, you can configure bot_account options (e.g.: bot_account: { author } or update_bot_account: { author }.

Or you can create a dedicated github account for squash and rebase operations, and use it in different bot_account options.

[mergify[bot]]

rebase

✅ Branch has been successfully rebased

[mergify[bot]]

This pull request now has conflicts with the target branch. Please resolve these conflicts and force push the updated branch.

[anoopcs9]

@synarete I hope we can close this now.