search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
120 stars 24 forks source link

github:add mergify configuration #275

Closed obnoxxx closed 1 year ago

obnoxxx commented 1 year ago

taken from samba-container / sambacc and adjusted.

Signed-off-by: Michael Adam obnox@samba.org

phlogistonjohn commented 1 year ago

In the commit message there should be a space after the colon.

fixed. we need commitlint or gitlint here ... 😉

phlogistonjohn commented 1 year ago

Also, in case you missed it there are syntax errors in the YAML that mergify is failing on.

obnoxxx commented 1 year ago

@anoopcs9 - now the whole make check and mrgify's config check both pass! :-)

obnoxxx commented 1 year ago

strange, after the latest update, check-yaml fails in the ci, but I can't see the error message in the output in the github UI ... @anoopcs9 , @phlogistonjohn - any idea?

anoopcs9 commented 1 year ago

strange, after the latest update, check-yaml fails in the ci, but I can't see the error message in the output in the github UI ... @anoopcs9 , @phlogistonjohn - any idea?

It's still the same failure. See https://github.com/samba-in-kubernetes/samba-operator/pull/275/files or https://github.com/samba-in-kubernetes/samba-operator/actions/runs/4075771638. Somehow your locally committed changes are not getting pushed properly.