search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
103 stars 24 forks source link

makefile: allow override KUBECTL_CMD #279

Closed synarete closed 1 year ago

synarete commented 1 year ago

When (developer is) running over OpenShift cluster it is typical to use the OpenShift Client CLI (oc[1]) utility instead of kubectl. Allow her to override Makefile's KUBECTL_CMD.

[1] https://github.com/openshift/oc

Signed-off-by: Shachar Sharon ssharon@redhat.com

phlogistonjohn commented 1 year ago

@mergifyio rebase

mergify[bot] commented 1 year ago

⚠️ This pull request got rebased on behalf of a random user of the organization. This behavior will change on the 1st February 2023, Mergify will pick the author of the pull request instead.

To get the future behavior now, you can configure bot_account options (e.g.: bot_account: { author } or update_bot_account: { author }.

Or you can create a dedicated github account for squash and rebase operations, and use it in different bot_account options.

mergify[bot] commented 1 year ago

rebase

✅ Branch has been successfully rebased

phlogistonjohn commented 1 year ago

Dear mergify, it is now Feb. 9th. ;-)

anoopcs9 commented 1 year ago

@Mergifyio rebase

mergify[bot] commented 1 year ago

⚠️ This pull request got rebased on behalf of a random user of the organization. This behavior will change on the 1st February 2023, Mergify will pick the author of the pull request instead.

To get the future behavior now, you can configure bot_account options (e.g.: bot_account: { author } or update_bot_account: { author }.

Or you can create a dedicated github account for squash and rebase operations, and use it in different bot_account options.

mergify[bot] commented 1 year ago

rebase

✅ Branch has been successfully rebased