search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
103 stars 24 forks source link

add default node selector value and configuration #286

Closed phlogistonjohn closed 1 year ago

phlogistonjohn commented 1 year ago

Related To: #283

Adds a default-node-selector configuration value and some hard coded default values. The hard coded defaults match what samba-container currently provides, images that work on x86_64 linux. Putting a json mapping in the config allows an admin/dev to customize the defaults without hacking the code or rebuilding the operator (say for example - experimenting with custom build images for arm64).

I plan on following this up with node selectors and affinity support as part of SmbCommonConfig.

phlogistonjohn commented 1 year ago

@synarete you'll need to use the approval at the review level if it looks OK because GH already dismissed your earlier LGTM. Thanks!