hack: Bump golangci-lint to v1.53.3

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes

Apache License 2.0

103 stars 24 forks source link

hack: Bump golangci-lint to v1.53.3 #288

Closed anoopcs9 closed 11 months ago

anoopcs9 commented 1 year ago

Removes already deprecated linter varcheck
Depguard now expects a list of allow/deny list and default rule is to allow only std lib in all files https://github.com/golangci/golangci-lint/issues/3877#issuecomment-1573682848. Therefore disable the linter.

depends on #313

anoopcs9 commented 1 year ago

Go 1.19 is a requirement here.

anoopcs9 commented 1 year ago

@anoopcs9 - the PR title says v1.51.2 but the commit says v1.47.3 - which one is it?

Actual change updates it to v1.51.2. Commit message is wrong here.

after putting this straight, I think we can move the PR out of draft status ...

As mentioned earlier,

Go 1.19 is a requirement here.

Therefore we'll have to wait until we update projects Go version to 1.19.

obnoxxx commented 1 year ago

@anoopcs9 wrote:

@obnoxxx wrote:

@anoopcs9 - the PR title says v1.51.2 but the commit says v1.47.3 - which one is it?

Actual change updates it to v1.51.2. Commit message is wrong here.

Got it, commit looks good. thanks for clarifying!

after putting this straight, I think we can move the PR out of draft status ...

As mentioned earlier,

Go 1.19 is a requirement here.

Therefore we'll have to wait until we update projects Go version to 1.19.

is this the reason for some ci checks failing?

anoopcs9 commented 1 year ago

after putting this straight, I think we can move the PR out of draft status ...

As mentioned earlier,

Go 1.19 is a requirement here.

Therefore we'll have to wait until we update projects Go version to 1.19.

is this the reason for some ci checks failing?

Yes.

obnoxxx commented 1 year ago

after putting this straight, I think we can move the PR out of draft status ...

As mentioned earlier,

Go 1.19 is a requirement here.

Therefore we'll have to wait until we update projects Go version to 1.19.

is this the reason for some ci checks failing?

Yes.

@anoopcs9 , I think if you move this out of draft, we can get it merged and take the next step to update the go version

obnoxxx commented 1 year ago

@mergifyio rebase

mergify[bot] commented 1 year ago

rebase

✅ Branch has been successfully rebased

phlogistonjohn commented 11 months ago

Removed priority-review label because this depends on #313

dpulls[bot] commented 11 months ago

:tada: All dependencies have been resolved !

obnoxxx commented 11 months ago

@mergifyio rebase

mergify[bot] commented 11 months ago

rebase

✅ Branch has been successfully rebased

anoopcs9 commented 11 months ago

/retest centos-ci/sink-clustered/mini-k8s-latest