Closed anoopcs9 closed 1 year ago
Go 1.19 is a requirement here.
@anoopcs9 - the PR title says v1.51.2 but the commit says v1.47.3 - which one is it?
Actual change updates it to v1.51.2. Commit message is wrong here.
after putting this straight, I think we can move the PR out of draft status ...
As mentioned earlier,
Go 1.19 is a requirement here.
Therefore we'll have to wait until we update projects Go version to 1.19.
@anoopcs9 wrote:
@obnoxxx wrote:
@anoopcs9 - the PR title says v1.51.2 but the commit says v1.47.3 - which one is it?
Actual change updates it to v1.51.2. Commit message is wrong here.
Got it, commit looks good. thanks for clarifying!
after putting this straight, I think we can move the PR out of draft status ...
As mentioned earlier,
Go 1.19 is a requirement here.
Therefore we'll have to wait until we update projects Go version to 1.19.
is this the reason for some ci checks failing?
after putting this straight, I think we can move the PR out of draft status ...
As mentioned earlier,
Go 1.19 is a requirement here.
Therefore we'll have to wait until we update projects Go version to 1.19.
is this the reason for some ci checks failing?
Yes.
after putting this straight, I think we can move the PR out of draft status ...
As mentioned earlier,
Go 1.19 is a requirement here.
Therefore we'll have to wait until we update projects Go version to 1.19.
is this the reason for some ci checks failing?
Yes.
@anoopcs9 , I think if you move this out of draft, we can get it merged and take the next step to update the go version
@mergifyio rebase
rebase
Removed priority-review
label because this depends on #313
:tada: All dependencies have been resolved !
@mergifyio rebase
rebase
/retest centos-ci/sink-clustered/mini-k8s-latest
depends on #313