search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
101 stars 24 forks source link

go.mod: upgrade to newer versions #307

Closed synarete closed 1 year ago

synarete commented 1 year ago

Upgrade logr, client-go and controller-runtime to newer versions which include various bug fixes. Align code with respect to changes in those libraries.

depends on #310

phlogistonjohn commented 1 year ago

Thanks! This has been on my TODO list for a while so I'm happy to see this happen. On quick skim most things look OK, but since it is a big commit I will need a bit more time to fully review.

phlogistonjohn commented 1 year ago

Commit message nitpick: change upgrade to newer versions to update packages to newer versions. That way we're clarify that it's not a bump of the required go version, but impacts the dependencies.

phlogistonjohn commented 1 year ago

@obnoxxx @spuiuk 2nd review please?

anoopcs9 commented 1 year ago

@Mergifyio rebase

mergify[bot] commented 1 year ago

rebase

✅ Branch has been successfully rebased

dpulls[bot] commented 1 year ago

:tada: All dependencies have been resolved !

anoopcs9 commented 1 year ago

@Mergifyio rebase

mergify[bot] commented 1 year ago

rebase

✅ Branch has been successfully rebased