search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
113 stars 24 forks source link

Bump minimum Go version to 1.19 #313

Closed anoopcs9 closed 1 year ago

anoopcs9 commented 1 year ago

depends on https://github.com/samba-in-kubernetes/samba-centosci/pull/28

anoopcs9 commented 1 year ago

Not urgent, we could wait till Go 1.21 is released(may be in 2-3 weeks time).

anoopcs9 commented 1 year ago

Not urgent, we could wait till Go 1.21 is released(may be in 2-3 weeks time).

Go 1.21 is out now.

anoopcs9 commented 1 year ago

Approved.

I agree with @obnoxxx that the build commit probably should be two commits but it doesn't bother me enough to block the PR.

Updated once more.

dpulls[bot] commented 1 year ago

:tada: All dependencies have been resolved !

anoopcs9 commented 1 year ago

/retest centos-ci/sink-clustered/mini-k8s-latest

phlogistonjohn commented 1 year ago

@obnoxxx or @synarete -- a 2nd review please