samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
113 stars 24 forks source link

hack: add go-version-check.sh script #315

Closed phlogistonjohn closed 1 year ago

phlogistonjohn commented 1 year ago

Related to, but not blocked on, #314

Add a script that validates the Dockefile (or other specified container files) or shows the list of current supported golang version images. The goal is to ensure we are continually using a supported Go version and not falling behind.

Add a new check-dockerfile-go-version makefile target and include it in the check target. This runs the recently added script to validate the version of golang used to build in container.

The downside of this approach is that PRs & other work unrelated to Golang may periodically break when Go issues a new major release. Let's try this for now and if it ends up getting really annoying we can try to do some other form of automation to alert us to the need of a version bump that doesn't interfere with unrelated work.