search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
113 stars 24 forks source link

build(deps): bump golang.org/x/net from 0.7.0 to 0.17.0 #317

Closed dependabot[bot] closed 10 months ago

dependabot[bot] commented 11 months ago

Bumps golang.org/x/net from 0.7.0 to 0.17.0.

Commits
  • b225e7c http2: limit maximum handler goroutines to MaxConcurrentStreams
  • 88194ad go.mod: update golang.org/x dependencies
  • 2b60a61 quic: fix several bugs in flow control accounting
  • 73d82ef quic: handle DATA_BLOCKED frames
  • 5d5a036 quic: handle streams moving from the data queue to the meta queue
  • 350aad2 quic: correctly extend peer's flow control window after MAX_DATA
  • 21814e7 quic: validate connection id transport parameters
  • a600b35 quic: avoid redundant MAX_DATA updates
  • ea63359 http2: check stream body is present on read timeout
  • ddd8598 quic: version negotiation
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/samba-in-kubernetes/samba-operator/network/alerts).
phlogistonjohn commented 10 months ago

@anoopcs9 this isn't being automerged due to the lack of success for check-success=centos-ci/sink-clustered/mini-k8s-latest (I think). Is there something we should do to enable that?

anoopcs9 commented 10 months ago

/test centos-ci/sink-clustered/mini-k8s-latest

anoopcs9 commented 10 months ago

@anoopcs9 this isn't being automerged due to the lack of success for check-success=centos-ci/sink-clustered/mini-k8s-latest (I think). Is there something we should do to enable that?

Hm, I'm wondering why automatic trigger didn't kick in 🤷🏻 . For now I have initiated a run with our usual GitHub comment.

phlogistonjohn commented 10 months ago

Hm, I'm wondering why automatic trigger didn't kick in 🤷🏻 . For now I have initiated a run with our usual GitHub comment.

I was just thinking about this and I bet that it is because this PR is automatically filed by dependabot. It treats dependabot as an non-admin user according to:

https://github.com/samba-in-kubernetes/samba-centosci/blob/ec0ae987e1f05326347f09be7d4490a382035cfa/jobs/sink-clustered-deployment.yml#L53-L60

We either need to remember to manually add the comment like you did OR add dependabot to this of PR submitters that automatically have the job run. Adding it to the list as an "admin" feels a bit weird to me tho. But I'll defer to your better knowledge of centosci if that's not a big deal.

anoopcs9 commented 10 months ago

Hm, I'm wondering why automatic trigger didn't kick in 🤷🏻 . For now I have initiated a run with our usual GitHub comment.

I was just thinking about this and I bet that it is because this PR is automatically filed by dependabot.

You are spot on.

We either need to remember to manually add the comment like you did OR add dependabot to this of PR submitters that automatically have the job run. Adding it to the list as an "admin" feels a bit weird to me tho.

Yeah..

But I'll defer to your better knowledge of centosci if that's not a big deal.

Let's continue with the manual intervention which I guess is only required in a monthly fashion(if any).