search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
117 stars 24 forks source link

ARM64 support #324

Open BojanZelic opened 10 months ago

BojanZelic commented 10 months ago

Have some rasberry pi's I was planning on running this on but the image doesn't have arm64 support. Adding support should be as simple as using docker buildx 

docker manifest inspect quay.io/samba.org/samba-operator:v0.4

{
        "schemaVersion": 2,
        "mediaType": "application/vnd.oci.image.manifest.v1+json",
        "config": {
                "mediaType": "application/vnd.oci.image.config.v1+json",
                "digest": "sha256:20295910427b9d52d2e6777585154a630bb7b276306983dc5c77a80d9bab2a11",
                "size": 7632
        },
        "layers": [
                {
                        "mediaType": "application/vnd.oci.image.layer.v1.tar+gzip",
                        "digest": "sha256:a032f50e22ae11b241fcf38b4a787f0e51009578eedaf9d05894f5f38fd12af5",
                        "size": 37718602
                },
                {
                        "mediaType": "application/vnd.oci.image.layer.v1.tar+gzip",
                        "digest": "sha256:c9467e3d8012e3d28ef1a251c8f2be9b564344bf155056d7ba2ab89dc8502e86",
                        "size": 23957809
                }
        ],
        "annotations": {
                "org.opencontainers.image.base.digest": "sha256:3e313209ac617a92b50350286752311d99ea2dafc429ef0e5311889294b0bc21",
                "org.opencontainers.image.base.name": "registry.access.redhat.com/ubi9/ubi-minimal:latest"
        }
}
alecthomas commented 8 months ago

Just wanted to add a vote for arm64 support.

fhauptmann commented 6 months ago

+1

alecthomas commented 5 months ago

I've built an arm64 image, available here, though I'd recommend anyone needing one to just roll their own. I just made some minor tweaks to the Makefile then built and pushed it using the provided instructions, then updated the nodeSelectors in the config.

alecthomas commented 5 months ago

The next problem is that somehow none of the other samba images are arm64 either, so I'm slowly going through building them all as well...very tedious:

quay.io/samba.org/samba-server
quay.io/samba.org/samba-metrics
quay.io/samba.org/svcwatch
synarete commented 5 months ago

smbmtrics is written in golang, so it should be rather simple to build it for arm64

phlogistonjohn commented 5 months ago

FWIW the issue with the samba-server images is not that it can not be built for arm64, but that we can not automate it. I have built arm64 images before with podman on x86_64 machines successfully. If folks are interested enough in arm64 support I'd like to have participation over in samba-containers ... even if folks just volunteered for help testing the images, it would be nice.