search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
113 stars 24 forks source link

CI needs updating #327

Closed phlogistonjohn closed 7 months ago

phlogistonjohn commented 7 months ago

Various CI checks have recently started failing. I'm not sure of this but I wonder if these are triggered by the recent release of Go 1.22.

The build container check also detects that we're no longer using a supported version of go the Dockerfile

anoopcs9 commented 7 months ago

As noticed in a different project this seems more likely due to latest revive(v1.3.7) release where it adds support to detect unused parameters for anonymous functions.

anoopcs9 commented 7 months ago

The build container check also detects that we're no longer using a supported version of go the Dockerfile

As noted in https://github.com/samba-in-kubernetes/samba-operator/pull/315

The downside of this approach is that PRs & other work unrelated to Golang may periodically break when Go issues a new major release.

first occurrence 😆