config: restrict deployments to amd64 nodes

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes

Apache License 2.0

120 stars 24 forks source link

config: restrict deployments to amd64 nodes #328

Closed synarete closed 9 months ago

synarete commented 9 months ago

Until samba-operator supports other architectures (namely, ARM64), restrict its deployment to AMD64 nodes (e.g., in cases of non x86_64 or mixed ARCH clusters) via standard K8s node-selector mechanism [1].

[1] https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/

depends on #329

dpulls[bot] commented 9 months ago

:tada: All dependencies have been resolved !

obnoxxx commented 9 months ago

@phlogistonjohn wrote.

It might be nice to clarify that your patch is an adaptation of the original contribution. Something like adding a 'Original-Version-By:' footer?

Not sure it is required because the original contributor @tiferrei of #326 is still t author of this PR's commit which also carries their signoff line

synarete commented 9 months ago

@synarete could you please add a Co-authored tag instead of your signoff to the commit message? I. E. Co-authored-by: Shachar Sharon <your email>

otherwise, this looks like a clean wrapping of PR #326

ACK

anoopcs9 commented 9 months ago

/retest centos-ci/sink-clustered/mini-k8s-latest