search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
120 stars 24 forks source link

Allow specification of annotations for the smbshare service #332

Open jpflouret opened 8 months ago

jpflouret commented 8 months ago

Adding annotations to the created servcie would allow for additional configuration of the created service. For example, with metallb you could specify the requested address pool to use. Another use case could be specifying the hostname to use with external-dns for registering the load balancer assigned IP address with an external DNS provider (which would address #147).

I would propose that the SmbCommonConfig resource should contain an annotations key either under network or under a new different key. Perhaps serviceSettings could be a sibling of podSettings and it could contain additional settings for the service (e.g. loadBalancerIP).

phlogistonjohn commented 8 months ago

Sounds generally reasonable to me. Having an annotations under network sounds fine to me. To be super clear we could also consider serviceAnnotations (also under network).

Please note that I have very little time for samba-operator myself these days, so depending on how strongly you want this you may want to look into implementing it yourself or finding someone. I am, of course, happy to review PRs and offer advice.