search

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes
Apache License 2.0
117 stars 24 forks source link

resources: fix failure to check returned errors from SetControllerReference #88

Closed phlogistonjohn closed 3 years ago

phlogistonjohn commented 3 years ago

This also makes the error logging calls consistent between the calls to SetControllerReference and the API calls to create/update/whatever the resource. This eliminates the functions that existed to create a resource type and then set the controller reference as it was easier to inline these "two line" functions than plumb error handling through everything.

NOTE: I expect this may cause the CI to fail. If so, that's a good thing. :-) But I want to see it first.

phlogistonjohn commented 3 years ago

Yup it failed. This means that issue #87 is on the right track and my recent changes in this area were incorrect. The good thing is that the CI actually catches a problem (tests were added as part of that work) once we add the appropriate error checking to the code.

Now's just a matter of deciding what to do for long term behavior wrt namespaces.

phlogistonjohn commented 3 years ago

Obsoleted by #100. Closing.