Use latest controller-gen code to avoid build problems

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes

Apache License 2.0

117 stars 24 forks source link

Use latest controller-gen code to avoid build problems #97

Closed gd closed 3 years ago

gd commented 3 years ago

Guenther

Signed-off-by: Günther Deschner gd@samba.org

phlogistonjohn commented 3 years ago

I tried this yesterday and it was not working for me (not submitted as a PR yet, for various reasons). The CI errors jives with what I saw... this latest version also changes the CLI options. You can try either going 1 version back which worked for me, or try fixing the CLI -- but I did the former because I couldn't find any docs explaining the new cli (and the built in help for controller-gen is rather hard to understand IMO).

phlogistonjohn commented 3 years ago

@gd how do you prefer to move forward with this one?

gd commented 3 years ago

Given the clarification we had later on I think we can close this one.