samba-in-kubernetes / sit-environment

SIT (Samba Integration Testing) Framework
GNU General Public License v3.0
1 stars 7 forks source link

have 3 MDSs (1 up while 2 in standby) for the backend ceph cluster #25

Open dparmar18 opened 1 year ago

dparmar18 commented 1 year ago

I'm not sure if I might be missing out on some code that I didn't look at but I was going through https://github.com/samba-in-kubernetes/sit-environment/pull/17 and it seems there's just one MDS being created, right? I'd say have at least 3 which makes it easy to handle any workload and/or any failure/crash in active MDS.

obnoxxx commented 1 year ago

Thanks for this suggestion, @dparmar18, this is very useful!

we can certainly look into adding this enhancement. @xhernandez , @phlogistonjohn - what do you think?

phlogistonjohn commented 1 year ago

Sure, it should just be a matter of setting the count for the placement spec. https://docs.ceph.com/en/latest/cephadm/services/mds/#deploy-cephfs

xhernandez commented 1 year ago

What's exactly the purpose of the additional MDS ?

If they are there just in case of a failure of the active MDS, I would prefer to catch that and see the failure. The purpose of this test environment is to identify functional issues in both Samba and CephFS to fix them and improve both projects, not to create a highly resilient environment (specially if this could hide some unwanted failures).

spuiuk commented 1 year ago

I agree with Xavi here. We are not testing cephfs directly but the cephfs over SMB and for that we don't really require 3 MDS machines which are required for high availability. That will simply take more resources and is not really tested.