search

samba-in-kubernetes / sit-environment

SIT (Samba Integration Testing) Framework
GNU General Public License v3.0
1 stars 7 forks source link

cluster-glusterfs: Disable disperse volume operations #61

Closed anoopcs9 closed 11 months ago

anoopcs9 commented 12 months ago

Test runs on disperse volumes doesn't proceed after a hung state and eventually gets timed out(6 hrs from CentOS CI maximum reservation time). Therefore limit the tests runs to just distribute-replicated volumes which seems to pass without any issues.

spuiuk commented 12 months ago

I don't see the point of continuing with replicated volume testing only if we don't intend on fixing problems we hit. Maybe we should probably switch off glusterfs testing in centos-ci instead. That way the code to do a more comprehensive test of glusterfs code is still available in easy reach.

spuiuk commented 12 months ago

From the meeting today - We investigate the cause of this problem to rule out issues in the test environment. We don't merge this PR. We run CentOS CI tests for glusterfs only for nightly runs and not for every PR. We investigate if we can manually set a label(or other mechanism) to tell the CI system that the changes should also be tested against GlusterFS.

anoopcs9 commented 12 months ago

From the meeting today - We investigate the cause of this problem to rule out issues in the test environment. We don't merge this PR.

Did you mean to investigate the hung state on running test suite for disperse volumes?

We run CentOS CI tests for glusterfs only for nightly runs and not for every PR. We investigate if we can manually set a label(or other mechanism) to tell the CI system that the changes should also be tested against GlusterFS.

Above suggestion is already available for review as https://github.com/samba-in-kubernetes/samba-centosci/pull/42. Awaiting reviews..

spuiuk commented 11 months ago

From the meeting today - We investigate the cause of this problem to rule out issues in the test environment. We don't merge this PR.

Did you mean to investigate the hung state on running test suite for disperse volumes?

Yes. Xavi offered to investigate when he has some time. This can take some time now that we have disabled glusterfs testing with each PR.(See below)

We run CentOS CI tests for glusterfs only for nightly runs and not for every PR. We investigate if we can manually set a label(or other mechanism) to tell the CI system that the changes should also be tested against GlusterFS.

Above suggestion is already available for review as samba-in-kubernetes/samba-centosci#42. Awaiting reviews..

Thanks - Acked and Mer

anoopcs9 commented 11 months ago

From the meeting today - We investigate the cause of this problem to rule out issues in the test environment. We don't merge this PR.

Did you mean to investigate the hung state on running test suite for disperse volumes?

Yes. Xavi offered to investigate when he has some time. This can take some time now that we have disabled glusterfs testing with each PR.(See below)

Why don't we then take in the change so that nightly runs can complete on just distribute-replicate volumes without getting timed out?

xhernandez commented 11 months ago

@anoopcs9 if we merge this PR, then there won't be any way to run disperse tests on centos-ci, right ?

To investigate the cause, I will need to be able to run some tests.

Is it possible to temporarily disable glusterfs tests on nightly builds ?

anoopcs9 commented 11 months ago

From the meeting today - We investigate the cause of this problem to rule out issues in the test environment. We don't merge this PR.

Did you mean to investigate the hung state on running test suite for disperse volumes?

Yes. Xavi offered to investigate when he has some time. This can take some time now that we have disabled glusterfs testing with each PR.(See below)

https://github.com/samba-in-kubernetes/sit-test-cases/issues/45 will further track the progress on hung issue with disperse volumes. Therefore abandoning the PR as investigation is underway to root cause the hung state.