search

samba-in-kubernetes / sit-environment

SIT (Samba Integration Testing) Framework
GNU General Public License v3.0
1 stars 7 forks source link

Fixes to adjust with latest ansible v2.16.3 #85

Closed anoopcs9 closed 9 months ago

anoopcs9 commented 9 months ago

Very recently on CentOS Stream 8 ansible version got updated to v2.16.3 built with Python 3.12. Due to unavailability of python 3.12 module for jmespath playbook execution is expected to fail. Therefore switch the python module installation from RPMs to pip where it can be versioned.

Additionally due to a regression in first_found plugin we switch to absolute paths wherever required to find OS specific files. See https://github.com/ansible/ansible/issues/82695 for more details.

depends on https://github.com/samba-in-kubernetes/samba-centosci/pull/54

anoopcs9 commented 9 months ago

Instead of adding version dependencies, couldn't we install jmespath using pip instead of the CentOS package ?

It is my guess that pip executable will also need to used accordingly with required Python version(pip3.11, pip3.12 etc). So its a choice between specifying ansible version and pip executable version. Let me verify that it is the case here.

anoopcs9 commented 9 months ago

Instead of adding version dependencies, couldn't we install jmespath using pip instead of the CentOS package ?

It is my guess that pip executable will also need to used accordingly with required Python version(pip3.11, pip3.12 etc). So its a choice between specifying ansible version and pip executable version. Let me verify that it is the case here.

Ok. I think I got it confused. I'll check by replacing jmespath python module installation from RPM to pip with required versioned executable.

anoopcs9 commented 9 months ago

/retest all

anoopcs9 commented 9 months ago

/retest all

I've manually adjusted required jobs to pick up https://github.com/samba-in-kubernetes/samba-centosci/pull/54 for their execution.

spuiuk commented 9 months ago

Isn't playbooks/roles/setup.prep/tasks/centos.yml being included anywhere? Can we get it to also install the module using pip?

anoopcs9 commented 9 months ago

Isn't playbooks/roles/setup.prep/tasks/centos.yml being included anywhere? Can we get it to also install the module using pip?

We discussed offline and decided to have pip installation step merged at playbooks/roles/setup.prep/tasks/centos{8,9}.yml.

dpulls[bot] commented 9 months ago

:tada: All dependencies have been resolved !