samba-in-kubernetes / sit-test-cases

SIT (Samba Integration Tests) Automated Test Cases
0 stars 4 forks source link

Tox deps #62

Closed spuiuk closed 5 months ago

spuiuk commented 5 months ago

Add required python dependency iso8601 to tox.ini

depends on #61

dpulls[bot] commented 5 months ago

:tada: All dependencies have been resolved !

anoopcs9 commented 5 months ago

I just discovered privileged is a custom mark. (i.e, pytest do not handle anything explicitly with this marker) How are we actually utilizing it? Any plans to call pytest on these tests differently? Or is it just for readability/understandability?

Dependent change #61 introduced new pytest target with -k as mentioned here in docs.

spuiuk commented 5 months ago

Let me re-base the branch to clear out all the old patches which have already been committed.

anoopcs9 commented 5 months ago

Add required python dependency iso8601 to tox.ini

Did we see any failure/warning? Why is it being added now?

spuiuk commented 5 months ago

Add required python dependency iso8601 to tox.ini

Did we see any failure/warning? Why is it being added now?

This is one of the dependencies installed using pip by the sit-environment on the client machine. Since we use tox to run the tests, we can instead get tox to handle these python library dependencies. Once this is merged, we can remove the pip package installations from the sit-environment repository.

https://github.com/samba-in-kubernetes/sit-environment/blob/main/playbooks/ansible/roles/client.prep/tasks/centos.yml

anoopcs9 commented 5 months ago

Add required python dependency iso8601 to tox.ini

Did we see any failure/warning? Why is it being added now?

This is one of the dependencies installed using pip by the sit-environment on the client machine. Since we use tox to run the tests, we can instead get tox to handle these python library dependencies. Once this is merged, we can remove the pip package installations from the sit-environment repository.

Nice.