search

samba-in-kubernetes / sit-test-cases

SIT (Samba Integration Tests) Automated Test Cases
0 stars 4 forks source link

flapping.xfs: Do not consider entire smb2.session as knownfail #67

Closed anoopcs9 closed 4 months ago

anoopcs9 commented 4 months ago

Most of the tests from smb2.session test suite passes successfully on XFS without any extra setup. Therefore be specific about subtests which are to be ignored due to lack of special and/or proper server setup.

spuiuk commented 4 months ago

This is also the case for glusterfs. Can you please fix it there too.

anoopcs9 commented 4 months ago

This is also the case for glusterfs. Can you please fix it there too.

I'm not sure about the current status as it is in disabled state for a while due to https://github.com/samba-in-kubernetes/sit-test-cases/issues/45. Should we still update simultaneously for GlusterFS?

spuiuk commented 4 months ago

I think we should then just go ahead with the current one. Better to test before adding the changes for glusterfs.

spuiuk commented 4 months ago

Hit these errors for centos-ci/xfs test. retesting to check if this was a transient error.

smbtorture 4.21.0pre1-UNKNOWN
Using seed 1707715874
time: 2024-02-12 05:31:14.858559Z
progress: 2
test: samba3.smb2.maximum_allowed.maximum_allowed
time: 2024-02-12 05:31:14.859175Z
Checked SEC_PRIV_RESTORE for S-1-5-21-3689626328-1371023801-1550821248-1000 - No
Checked SEC_PRIV_BACKUP for S-1-5-21-3689626328-1371023801-1550821248-1000 - No
Checked SEC_PRIV_SECURITY for S-1-5-21-3689626328-1371023801-1550821248-1000 - No
time: 2024-02-12 05:31:14.886761Z
xfail: samba3.smb2.maximum_allowed.maximum_allowed [
Exception: ../../source4/torture/smb2/max_allowed.c:161: status was NT_STATUS_ACCESS_DENIED, expected NT_STATUS_OK: Incorrect status NT_STATUS_ACCESS_DENIED - should be NT_STATUS_OK

]
test: samba3.smb2.maximum_allowed.read_only
time: 2024-02-12 05:31:14.886788Z
time: 2024-02-12 05:31:14.904874Z
failure: samba3.smb2.maximum_allowed.read_only [
Exception: ../../source4/torture/smb2/max_allowed.c:212: status was NT_STATUS_OBJECT_NAME_COLLISION, expected NT_STATUS_OK: smb2_create failed

]
spuiuk commented 4 months ago

/retest centos-ci/xfs

anoopcs9 commented 4 months ago

Hit these errors for centos-ci/xfs test. retesting to check if this was a transient error.

smbtorture 4.21.0pre1-UNKNOWN
Using seed 1707715874
time: 2024-02-12 05:31:14.858559Z
progress: 2
test: samba3.smb2.maximum_allowed.maximum_allowed
time: 2024-02-12 05:31:14.859175Z
Checked SEC_PRIV_RESTORE for S-1-5-21-3689626328-1371023801-1550821248-1000 - No
Checked SEC_PRIV_BACKUP for S-1-5-21-3689626328-1371023801-1550821248-1000 - No
Checked SEC_PRIV_SECURITY for S-1-5-21-3689626328-1371023801-1550821248-1000 - No
time: 2024-02-12 05:31:14.886761Z
xfail: samba3.smb2.maximum_allowed.maximum_allowed [
Exception: ../../source4/torture/smb2/max_allowed.c:161: status was NT_STATUS_ACCESS_DENIED, expected NT_STATUS_OK: Incorrect status NT_STATUS_ACCESS_DENIED - should be NT_STATUS_OK

]
test: samba3.smb2.maximum_allowed.read_only
time: 2024-02-12 05:31:14.886788Z
time: 2024-02-12 05:31:14.904874Z
failure: samba3.smb2.maximum_allowed.read_only [
Exception: ../../source4/torture/smb2/max_allowed.c:212: status was NT_STATUS_OBJECT_NAME_COLLISION, expected NT_STATUS_OK: smb2_create failed

]

See https://github.com/samba-in-kubernetes/sit-test-cases/issues/66. I have a possible pending merge request in upstream.

spuiuk commented 4 months ago

Thanks. Looks good.