search

samba-in-kubernetes / sit-test-cases

SIT (Samba Integration Tests) Automated Test Cases
0 stars 4 forks source link

Use python module pysmbc instead of smbclient #74

Closed spuiuk closed 3 months ago

spuiuk commented 3 months ago

This change introduces a new class SMBClient which is a wrapper around the python module pysmbc. This simplifies access to samba server as demonstrated in the changes to the consistency test which used to use smbclient to access the server.

Note that this changeset consists of only one commit and the rest of the commits are from #73

depends on #73 depends on https://github.com/samba-in-kubernetes/sit-environment/pull/93

spuiuk commented 3 months ago

PR #76 opened which uses a different python smb client module which should be easier to install and use on our test systems. Leaving both open as we decide which module to go ahead with.

dpulls[bot] commented 3 months ago

:tada: All dependencies have been resolved !

spuiuk commented 3 months ago

Closing this PR in favour of PR #76

The pysmbc module is the python bindings for the libsmb client library. This means that when installing using pip, we need to recompile the module. This requires additional development packages installed on the test systems. Instead we use the pysmb module which is a pure python module which is easier to use with the test system.