search

sambacha / yearn-finance-tokenlist

Yearn Finance Ecosystem Tokenlist
8 stars 1 forks source link

Syntax error in index.js #82

Closed DannyDelott closed 2 years ago

DannyDelott commented 3 years ago

Hi there, I was poking around this repo for inspiration for a different tokenlist repo and noticed that the modules.exports syntax looks malformed here, ie: it's missing the key part of the key/value pair.

https://github.com/sambacha/yearn-finance-tokenlist/blob/f60b5b9f6809e09376fe44f668f4d43170bb2d2e/index.js#L1-L5

sambacha commented 3 years ago

Hey, thanks for letting me know. This happened as i was copy pasting from the now official list to this repo. You should look to yearn.science for the official tokenlist anyways!

sambacha commented 3 years ago

just a follow up, you might find this useful:

# tokenlists.env 
WRAPPED=https://wrapped.tokensoft.eth.link/
YEARN=https://yearn.science/static/tokenlist.json
SUSHISWAP=https://raw.githubusercontent.com/sushiswapclassic/token-list/master/sushiswap.tokenlist.json
ONE_INCH=https://tokens.1inch.eth.link
COINGECKO=https://tokens.coingecko.com/uniswap/all.json
COMPOUND=https://raw.githubusercontent.com/compound-finance/token-list/master/compound.tokenlist.json
DEFIPRIME=https://defiprime.com/defiprime.tokenlist.json
MESSARI=https://messari.io/tokenlist/messari-verified
OPYN=https://raw.githubusercontent.com/opynfinance/opyn-tokenlist/master/opyn-v1.tokenlist.json
SNX=https://synths.snx.eth.link/
SET=https://raw.githubusercontent.com/SetProtocol/uniswap-tokenlist/main/set.tokenlist.json
AVE=https://tokenlist.aave.eth.link
AGORA=https://datafi.theagora.eth.link
CMCDEFI=https://defi.cmc.eth.link
CMCSTABLECOIN=https://stablecoin.cmc.eth.link
CMC200ERC20=https://erc20.cmc.eth.link
KLEROS=https://t2crtokens.eth.link
FURUCOMBO=https://cdn.furucombo.app/furucombo.tokenlist.json
KYBER=https://api.kyber.network/tokenlist
MYCRYPTOAPI=https://uniswap.mycryptoapi.com/
ZAPPER=https://zapper.fi/api/token-list
ZERION=https://tokenlist.zerion.eth.link

Additionally, here is an example of how Argent uses something similar to token lists https://cloud.argent-api.com/v1/tokens/?

sambacha commented 2 years ago

https://yearn.science/static/tokenlist.json