Jayr/bugfix/sha256 dir exists - Githubissues

sambanova / generative_data_prep

Apache License 2.0

58 stars 8 forks source link

Jayr/bugfix/sha256 dir exists #68

Closed snova-jayr closed 11 months ago

snova-jayr commented 11 months ago

Please refer to CONTRIBUTING.md for detailed instructions.

Summary

Since the sha256 metajson file already exists, it will error out unless the sha directory is deleted if the output directory already exists.

Also a small nit I had was that the file extensions were being saved differently in the SHA, which doesn't lead to any errors but wanted to fix that

PR Checklist

[x] My PR is less than 500 lines of code
[x] I have added sufficient comment as docstrings in my code
[x] I have made corresponding changes to the documentation
[x] I have written unit-tests to test all of my code